Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[res] Add TFLiteRecipe for dynamic shape StridedSlice #14156

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

qsunki
Copy link
Contributor

@qsunki qsunki commented Oct 4, 2024

This commit adds TFLiteRecipe for dynamic shape StridedSlice.

ONE-DCO-1.0-Signed-off-by: sunki [email protected]


@qsunki qsunki added the SSAFY label Oct 4, 2024
@qsunki qsunki requested review from seanshpark and a team October 4, 2024 01:26
@shs-park shs-park requested a review from a team October 4, 2024 08:31
shs-park
shs-park previously approved these changes Oct 4, 2024
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment.
Anyway the code LGTM!
=)

name: "ofm"
type: FLOAT32
shape { dim: 1 dim: 0 dim: 0 dim: 5 }
shape_signature { dim: 1 dim: -1 dim: -1 dim: 5 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this comment for the record.

Theoretically, in this case, it seems that the shape of the output tenser can be determined by the begin, end, and stride values.

I think this can be solved by updating the tflite code part together later.

I will create a separate issue related to this.

This commit adds TFLiteRecipe for dynamic shape StridedSlice.

ONE-DCO-1.0-Signed-off-by: sunki <[email protected]>
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit ad1d197 into Samsung:master Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants