Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[res] Introduce Reshape_004 tflite recipe #14151

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

seanshpark
Copy link
Contributor

This will introduce Reshape_004 tflite recipe with 0 in shape.

This will introduce Reshape_004 tflite recipe with 0 in shape.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
@seanshpark
Copy link
Contributor Author

@seanshpark seanshpark requested a review from a team October 2, 2024 08:24
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question, PTAL.
=)

name: "shape"
type: INT32
shape { dim: 3 }
filler { tag: "explicit" arg: "0" arg: "3" arg: "-1" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question,
Is 0 value always converted to 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This situation is from ONNX, where dim 0 will follow that from input, not to 1.
As of now, I've only seen model with input with dim value of 1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanshpark seanshpark merged commit e07380e into Samsung:master Oct 2, 2024
8 checks passed
@seanshpark seanshpark deleted the res_reshape_004 branch October 2, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants