Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert/train] Add LayerScopeManager into TensorManager #14047

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

zetwhite
Copy link
Contributor

This PR adds LayerScopeManager into TensorManager.

ONE-DCO-1.0-Signed-off-by: seunghui youn [email protected]

draft : #13486
for : #13282

@zetwhite zetwhite marked this pull request as ready for review September 26, 2024 01:33
This PR adds LayerScopeManager into TensorManager.

ONE-DCO-1.0-Signed-off-by: seunghui youn <[email protected]>

draft : Samsung#13486
for : Samsung#13282
@zetwhite zetwhite requested a review from ragmani September 26, 2024 01:47
@zetwhite zetwhite added the PR/ready for review It is ready to review. Please review it. label Sep 26, 2024
@zetwhite zetwhite requested review from a team and ragmani and removed request for ragmani September 26, 2024 01:47
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zetwhite zetwhite requested a review from a team September 27, 2024 06:17
@zetwhite
Copy link
Contributor Author

@Samsung/one_onert
Can I merge this PR with 1 approval? Or could somebody review this PR?

Of course, I'd like to get another approval from others, but I am worried that there might not be enough people interested in reviewing it.

@ragmani
Copy link
Contributor

ragmani commented Oct 2, 2024

@Samsung/one_onert
Could you review this PR or merge this PR if one approval is fine?

@glistening
Copy link
Contributor

@hseok-oh and @chunseoklee agreed to merge with 1 approval for training.

@glistening glistening merged commit c7bd3d2 into Samsung:master Oct 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants