[luci/service] Support shape inference for non-const paddings #13949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR supports infer shape of pad operation with dynamic paddings. ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
icodo98
force-pushed
the
non_const_paddings
branch
from
b026ead
to
c73bb2c
Compare
seanshpark
reviewed
Sep 8, 2024
seanshpark
reviewed
Sep 8, 2024
seanshpark
reviewed
Sep 8, 2024
seanshpark
reviewed
Sep 8, 2024
seanshpark
reviewed
Sep 8, 2024
fix typo of annotation and adjust lines withs suggestions. ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
seanshpark
reviewed
Sep 8, 2024
icodo98
changed the title
icodo98
force-pushed
the
non_const_paddings
branch
from
fdf22cc
to
fb1e9cf
Compare
Change TC to have direct relation with changed code. ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
icodo98
force-pushed
the
non_const_paddings
branch
from
fb1e9cf
to
0bd9ee0
Compare
shs-park
reviewed
Sep 9, 2024
remove it and discuss about it in another issue. ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
remove unnecessary line. Co-authored-by: SaeHie Park <[email protected]>
shs-park
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports infer shape of pad operation with dynamic paddings.
ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]