[onert] Load tensor and optimizer data from the checkpoint file #13918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
ragmani
reviewed
Sep 4, 2024
Comment on lines
68
to
69
| assert(i <= _offset.size()); | ||
| return DataBufferPair{_offset[i], _size[i]}; |
There was a problem hiding this comment.
Unlike std::map::operator[], std::vector::operator[] never inserts a new element into the container.
Suggested change
| assert(i <= _offset.size()); | |
| return DataBufferPair{_offset[i], _size[i]}; | |
| assert(i < _offset.size()); | |
| return DataBufferPair{_offset[i], _size[i]}; |
| // Reset EOF bit | ||
| _file.clear(); | ||
|
|
||
| auto vindex = 0; |
There was a problem hiding this comment.
(optional)
How about using an explicit type like the above vindex?
Suggested change
| auto vindex = 0; | |
| uint32_t vindex = 0; |
| void updateAdamOptimizer(const std::unique_ptr<onert::exec::Execution> &exec) | ||
| { | ||
| // Adam optimizer has two optimizer variables. (mean, variance) | ||
| [[maybe_unused]] constexpr auto ADAM_VARIABLE_COUNT = 2; |
There was a problem hiding this comment.
(Optional)
How about using an explicit type? This variable is used for comparing unsigned integer.
By the way, is this initializing variable as constexpr is meaningful? this variable seems to be used in runtime, not compile time.
zetwhite
previously approved these changes
Sep 6, 2024
This commit loads tensor and optimizer data from the checkpoint file. ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
jyoungyun
force-pushed
the
240903/load_checkpoint_data
branch
from
4776cb0 to
3906443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit loads tensor and optimizer data from the checkpoint file.
ONE-DCO-1.0-Signed-off-by: Jiyoung Yun [email protected]
Related issue: #13670
Draft: #13561