[onert] Add lifetime enum to LayerScopeTensor #13861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetwhite
commented
Aug 30, 2024
Comment on lines
+29
to
+33
| enum class LayerScopeTensorLifeTime : unsigned char | ||
| { | ||
| BACKWARD, // alive during backward() | ||
| FORWARD_TO_BACKWARD, // alive from forward() to backward() | ||
| }; |
There was a problem hiding this comment.
Lifetime info will be used to plan and allocate a buffer for LayerScopeTensor.
This PR adds lifetime info to the LayerScopeTensor. Lifetime info will be used to plan and allocate buffer for LayerScopeTensor. ONE-DCO-1.0-Signed-off-by: seunghui youn <[email protected]>
zetwhite
force-pushed
the
0830/lstensor-lftime
branch
from
c1cc989 to
fa33a00
Compare
zetwhite
changed the title
jyoungyun
reviewed
Sep 2, 2024
| @@ -26,6 +26,12 @@ namespace backend | |||
| namespace train | |||
| { | |||
|
|
|||
| enum class LayerScopeTensorLifeTime : unsigned char | |||
There was a problem hiding this comment.
(out of my curiosity)
Why do you set a type for this enumaration class? What is the advantages?
There was a problem hiding this comment.
AFAIK, if we didn't set a type(enum-base) for enum class, the enum element takes 4 bytes by default.
In this case, I'd like to reduce the size of enum element. (default : 4bytes -> unsigned char 1bytes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lifetime info to the LayerScopeTensor. Lifetime info will be used to plan and allocate buffer for LayerScopeTensor.
ONE-DCO-1.0-Signed-off-by: seunghui youn [email protected]
related : #13282
draft : #13486