Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Rename ExtraTensor to LayerScopeTensor #13845

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

zetwhite
Copy link
Contributor

@zetwhite zetwhite commented Aug 29, 2024

This PR renames ExtraTensor to LayerSocpeTensor.

ONE-DCO-1.0-Signed-off-by: seunghui youn [email protected]

This PR renames ExtraTensor to LayerSocpeTensor.

ONE-DCO-1.0-Signed-off-by: seunghui youn <[email protected]>
@zetwhite zetwhite requested a review from a team August 29, 2024 11:22
@zetwhite zetwhite added the PR/ready for review It is ready to review. Please review it. label Aug 29, 2024
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +29 to +30
// LayerScopeTensor is a tensor that is not shown in graph but required by each layer.
// It is accessed within one operation layer.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note)
I also fixed the sentence here.

Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zetwhite
Copy link
Contributor Author

@glistening Could you take a look?

Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. LayerScopeTensor looks better than general ExtraTensor.

@hseok-oh hseok-oh merged commit 05eee35 into Samsung:master Aug 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants