-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onert] Rename ExtraTensor to LayerScopeTensor #13845
Conversation
This PR renames ExtraTensor to LayerSocpeTensor. ONE-DCO-1.0-Signed-off-by: seunghui youn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// LayerScopeTensor is a tensor that is not shown in graph but required by each layer. | ||
// It is accessed within one operation layer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(note)
I also fixed the sentence here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@glistening Could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. LayerScopeTensor
looks better than general ExtraTensor
.
This PR renames ExtraTensor to LayerSocpeTensor.
ONE-DCO-1.0-Signed-off-by: seunghui youn [email protected]