[mio-circle08] Revise to support ext_offset #13708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will revise to support ext_offset with - enable mutable methods with generated schema - enable to read Buffer offset/size attributes ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
seanshpark
force-pushed
the
miocir_rev_reader_mutsch
branch
from
417d443
to
9850566
Compare
mhs4670go
approved these changes
Aug 20, 2024
| @@ -45,6 +46,28 @@ Reader::Reader(const ::circle::Model *model) | |||
| } | |||
| } | |||
|
|
|||
| Reader::Reader(const ::circle::Model *model, const std::vector<char> *rawdata) | |||
There was a problem hiding this comment.
(optional)
Suggested change
| Reader::Reader(const ::circle::Model *model, const std::vector<char> *rawdata) | |
| Reader::Reader(const ::circle::Model *model, const std::vector<char> *rawdata): Reader(model) | |
| { | |
| _rawdata = rawdata; | |
| } |
There was a problem hiding this comment.
Ah, I'm planning to remove old Reader::Reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will revise to support ext_offset with