[onert] Fix DepthwiseConvOp kernel condition #13689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes DepthwiseConvOp kernel usage condition. Eigen kernel is not supproting different width-height stride yet. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
added
PR/ready for review
jyoungyun
reviewed
Aug 19, 2024
| if (_dilationWidth == 1 && _dilationHeight == 1) | ||
| // Since DepthwiseConvOp does not support dilation and different W/H stride yet, | ||
| // it uses the existing kernel in this case. | ||
| if (_dilationWidth == 1 && _dilationHeight == 1 && _strideWidth == _strideHeight) |
There was a problem hiding this comment.
The prepareF32 function must also be updated to add new constraints.
Thank you!
Update prepareF32 condition too.
ragmani
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes DepthwiseConvOp kernel usage condition.
Eigen kernel is not supproting different width-height stride yet.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]
Resolve #13675 and coverage test fail