Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[luci/lang] Add remove graph method #13647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[luci/lang] Add remove graph method #13647

wants to merge 1 commit into from

Conversation

BalyshevArtem
Copy link
Contributor

This pr adds removeGraphByIndex method to the Module.

from #13628

ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]

[luci/lang] Add remove graph method
a347df5 
This pr adds removeGraphByIndex method to the Module.

ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
@BalyshevArtem BalyshevArtem added the approval: 2 Require at least 2 approvals label Aug 12, 2024
@seanshpark
Copy link
Contributor

I've not finished with your draft review so I'm not going to check this PR before that.
1/ I don't understand why #13628 is separated
2/ #13628 itself doesn't have any pass dredd and value test

So, please please work with #13602 with full dredd and value test with your target Op/Network model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approval: 2 Require at least 2 approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BalyshevArtem @seanshpark