Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Introduce ExtraTensorIndex #13605

Merged
merged 2 commits into from
Aug 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions runtime/onert/backend/train/ExtraTensorIndex.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
/*
* Copyright (c) 2024 Samsung Electronics Co., Ltd. All Rights Reserved
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#ifndef __ONERT_BACKEND_TRAIN_EXTRA_TENSOR_INDEX_H__
#define __ONERT_BACKEND_TRAIN_EXTRA_TENSOR_INDEX_H__

#include <ir/Index.h>

#include <cassert>

namespace onert
{
namespace backend
{
namespace train
{

class ExtraTensorIndex
{
public:
ExtraTensorIndex(const ir::OperationIndex &op_index, uint32_t sub_index)
: _op_index{op_index}, _sub_index{sub_index}
{
assert(op_index.valid());
}

public:
const ir::OperationIndex &op_index() const { return _op_index; }
uint32_t sub_index() const { return _sub_index; }

bool operator==(const ExtraTensorIndex &other) const
{
return _op_index == other.op_index() && _sub_index == other.sub_index();
}
bool operator!=(const ExtraTensorIndex &other) const { return !(*this == other); }

private:
ir::OperationIndex _op_index;
uint32_t _sub_index;
};

inline std::ostream &operator<<(std::ostream &o, const ExtraTensorIndex &i)
{
o << i.op_index() << "-" << i.sub_index();
return o;
}

} // namespace train
} // namespace backend
} // namespace onert

namespace std
{

template <> struct hash<onert::backend::train::ExtraTensorIndex>
{
size_t operator()(const onert::backend::train::ExtraTensorIndex &index) const noexcept
{
const auto op_index = index.op_index();
const auto sub_index = index.sub_index();

assert(sizeof(op_index) <= sizeof(uint32_t));
static_assert(sizeof(size_t) >= sizeof(uint32_t),
"ExtraTensorIndex's hash creation error, size_t size is less than uint32_t");
Comment on lines +76 to +77
Copy link
Contributor

@glistening glistening Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) Personally, I prefer to remove this assert.

In general, sizeof(size_t) is 4 on 32-bit system, 8 on 64-bit system. Both cases, it is >= 4 (= sizeof(uint32_t)).

If any, I don't think onert will support such kind of system.


return (static_cast<size_t>(op_index.value())) << 16 | static_cast<size_t>(sub_index);
}
};

} // namespace std

#endif // __ONERT_BACKEND_TRAIN_EXTRA_TENSOR_INDEX_H__