[onert/onert_run] Use arser for onert_run #13549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hseok-oh
force-pushed
the
arser_onert_run
branch
2 times, most recently
from
4171c5b
to
ded8151
Compare
This commit updates onert_run to use arser for argument parsing instead of boost::program_options. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
force-pushed
the
arser_onert_run
branch
from
ded8151
to
f3b7669
Compare
zetwhite
reviewed
Jul 31, 2024
| #include <cassert> | ||
| #include <chrono> | ||
| #include <climits> |
There was a problem hiding this comment.
Why climits newly included here?
There was a problem hiding this comment.
I don't know exact reason, but it might be included from boost/program_options.hpp. Without this, we meet build fail on line 491's PATH_MAX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates onert_run to use arser for argument parsing instead of boost::program_options.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]
Draft: #13366