Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/pass] Support Div in ConvertNCHWToNHWC #13525

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

jinevening
Copy link
Contributor

This supports Div in ConvertNCHWToNHWC.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]

This supports Div in ConvertNCHWToNHWC.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
@jinevening jinevening requested a review from a team July 26, 2024 05:28
}
else
{
// Ignore if MUL does not have a const_node input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Ignore if MUL does not have a const_node input.
// Ignore if DIV does not have a const_node input.

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinevening jinevening merged commit 237bf23 into Samsung:master Jul 29, 2024
7 checks passed
@jinevening jinevening deleted the luci/nchw_to_nhwc_div branch July 29, 2024 06:02
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants