Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Plan gradient tensors on train backend #13523

Merged

Conversation

ragmani
Copy link
Contributor

@ragmani ragmani commented Jul 25, 2024

This commit adds planning gradient tensors used on train backend.

ONE-DCO-1.0-Signed-off-by: ragmani [email protected]

This commit adds planning gradient tensors used on train backend.

ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
@ragmani ragmani force-pushed the onert/training/plan_gradient_tensor branch from a2c4379 to 9447a61 Compare July 26, 2024 02:08
@ragmani ragmani requested a review from a team July 26, 2024 02:08
@ragmani ragmani added the PR/ready for review It is ready to review. Please review it. label Jul 26, 2024
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun requested a review from a team July 29, 2024 01:35
// TODO Plan gradient tensors
VERBOSE(BackendContext) << "Start planning gradient tensors" << std::endl;

// TODO Use DisposableTensor instread of GradientTensor to plan them together if possible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO Use DisposableTensor instread of GradientTensor to plan them together if possible
// TODO Use DisposableTensor instead of GradientTensor to plan them together if possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ragmani Please fix typo later

Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hseok-oh hseok-oh merged commit 077b19e into Samsung:master Jul 29, 2024
9 checks passed
@ragmani ragmani deleted the onert/training/plan_gradient_tensor branch July 29, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants