Skip to content

Commit

Permalink
[compute/cker] Remove the storage order parametrization from BatchMat…
Browse files Browse the repository at this point in the history
…Mul (#14371)

* [compute/cker] Remove the storage order parametrization from BatchMatMul

This commit removes the obsolete parametrization of the BatchMatMul x86 optimized kernel. The reason is that the storage order attribute of the MatrixParams class is later ignored by the x86 Gemm implementation using Eigen.

ONE-DCO-1.0-Signed-off-by: Tomasz Dolbniak [email protected]

* Revert the storage order with some comments
  • Loading branch information
tomdol authored Nov 28, 2024
1 parent d67ebbc commit 0d5f1c8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions compute/cker/include/cker/operation/optimized/BatchMatMul.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,17 @@ inline void BatchMatMul(const BatchMatMulParams &params, const float *lhs_data,
const float *rhs_data, float *output_data)
{
MatrixParams<float> lhs_params;
lhs_params.order = Order::kRowMajor;
lhs_params.order = Order::kRowMajor; // ignored by GemmImplUsingEigen
lhs_params.rows = params.lhs_rows;
lhs_params.cols = params.lhs_cols;

MatrixParams<float> rhs_params;
rhs_params.order = Order::kRowMajor;
lhs_params.order = Order::kRowMajor; // ignored by GemmImplUsingEigen
rhs_params.rows = params.rhs_rows;
rhs_params.cols = params.rhs_cols;

MatrixParams<float> dst_params;
dst_params.order = Order::kRowMajor;
lhs_params.order = Order::kRowMajor; // ignored by GemmImplUsingEigen
dst_params.rows = params.lhs_rows;
dst_params.cols = params.rhs_cols;

Expand Down

0 comments on commit 0d5f1c8

Please sign in to comment.