Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix links in the quick-start-guide-and-build.md #495

Merged
merged 1 commit into from
Apr 22, 2024
Merged

chore: Fix links in the quick-start-guide-and-build.md #495

merged 1 commit into from
Apr 22, 2024

Conversation

tdrozdovsky
Copy link
Collaborator

Pull Request

Description

Incorrect links that can lead to difficulties in setting up the LPVS correctly

Type of change

  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tdrozdovsky tdrozdovsky added the documentation Improvements or additions to documentation label Apr 22, 2024
@tdrozdovsky tdrozdovsky added this to the v1.5.0 milestone Apr 22, 2024
@tdrozdovsky tdrozdovsky self-assigned this Apr 22, 2024
m-rudyk
m-rudyk approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

o-kopysov
o-kopysov approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

userai-dev
userai-dev approved these changes Apr 22, 2024
View reviewed changes
Copy link

@userai-dev userai-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@o-kopysov o-kopysov merged commit b3ae2ec into Samsung:main Apr 22, 2024
8 checks passed
o-konoval
o-konoval approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-naumenko t-naumenko t-naumenko approved these changes

@m-rudyk m-rudyk m-rudyk approved these changes

@o-konoval o-konoval o-konoval approved these changes

@userai-dev userai-dev userai-dev approved these changes

@o-kopysov o-kopysov o-kopysov approved these changes

@tiokim tiokim Awaiting requested review from tiokim tiokim is a code owner

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees

@tdrozdovsky tdrozdovsky

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tdrozdovsky @o-kopysov @userai-dev @o-konoval @m-rudyk @t-naumenko