-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix one more Svace defect #492
Conversation
Signed-off-by: Oleg Kopysov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
============================================
+ Coverage 91.27% 91.34% +0.06%
Complexity 510 510
============================================
Files 48 48
Lines 1685 1686 +1
Branches 205 205
============================================
+ Hits 1538 1540 +2
Misses 82 82
+ Partials 65 64 -1 ☔ View full report in Codecov by Sentry. |
@@ -155,6 +155,7 @@ | |||
<goal>single</goal> | |||
</goals> | |||
<configuration> | |||
<appendAssemblyId>true</appendAssemblyId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we include this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assembly plugin option is changed to True to avoid build warnings.
Signed-off-by: Oleg Kopysov <[email protected]>
Pull Request
Description
Current PR fixes one more Svace defect.
Also, the assembly plugin option is changed to True to avoid build warnings.
Type of change
Please delete options that are not relevant.
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Checklist: