Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix one more Svace defect #492

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix: Fix one more Svace defect #492

merged 2 commits into from
Apr 10, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR fixes one more Svace defect.
Also, the assembly plugin option is changed to True to avoid build warnings.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.2

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the fix label Apr 10, 2024
@o-kopysov o-kopysov added this to the v1.4.3 milestone Apr 10, 2024
@o-kopysov o-kopysov self-assigned this Apr 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (53193bf) to head (5022219).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #492      +/-   ##
============================================
+ Coverage     91.27%   91.34%   +0.06%     
  Complexity      510      510              
============================================
  Files            48       48              
  Lines          1685     1686       +1     
  Branches        205      205              
============================================
+ Hits           1538     1540       +2     
  Misses           82       82              
+ Partials         65       64       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -155,6 +155,7 @@
<goal>single</goal>
</goals>
<configuration>
<appendAssemblyId>true</appendAssemblyId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we include this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assembly plugin option is changed to True to avoid build warnings.

@o-kopysov o-kopysov merged commit 2155207 into main Apr 10, 2024
10 checks passed
@o-kopysov o-kopysov deleted the fix-svace-2 branch April 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants