Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Svace defects and update unit tests #491

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: Fix Svace defects and update unit tests #491

merged 1 commit into from
Apr 10, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR contains fixes for Svace defects.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.2

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the fix label Apr 9, 2024
@o-kopysov o-kopysov added this to the v1.4.3 milestone Apr 9, 2024
@o-kopysov o-kopysov self-assigned this Apr 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.27%. Comparing base (15140e7) to head (1477271).

Files Patch % Lines
src/main/java/com/lpvs/entity/LPVSFile.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #491      +/-   ##
============================================
+ Coverage     91.02%   91.27%   +0.25%     
- Complexity      509      510       +1     
============================================
  Files            48       48              
  Lines          1816     1685     -131     
  Branches        220      205      -15     
============================================
- Hits           1653     1538     -115     
+ Misses           96       82      -14     
+ Partials         67       65       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 53193bf into main Apr 10, 2024
10 checks passed
@o-kopysov o-kopysov deleted the fix-deps branch April 10, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants