Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct link in quick-start-guide-and-build.md #469

Conversation

o-konoval
Copy link
Collaborator

@o-konoval o-konoval commented Mar 26, 2024

Pull Request

Description

Correct typo in link address related to the API Documentation file.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.2
  • fix related to link in documentation file

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-konoval o-konoval added bug Something isn't working documentation Improvements or additions to documentation fix labels Mar 26, 2024
@o-konoval o-konoval added this to the v1.4.3 milestone Mar 26, 2024
@o-konoval o-konoval self-assigned this Mar 26, 2024
@o-kopysov
Copy link
Collaborator

@o-konoval please sign the commit

Need to correct link in quick-start-guide-and-build.md related to the API Documentation.

Signed-off-by: Oleg Konoval <[email protected]>
@o-konoval o-konoval force-pushed the fix-Correct-link-in-quick-start-guide-and-build.md branch from dca2292 to 6ba9960 Compare March 26, 2024 14:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (f649078) to head (6ba9960).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #469   +/-   ##
=========================================
  Coverage     90.91%   90.91%           
  Complexity      491      491           
=========================================
  Files            47       47           
  Lines          1750     1750           
  Branches        210      210           
=========================================
  Hits           1591     1591           
  Misses           93       93           
  Partials         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-konoval
Copy link
Collaborator Author

@o-konoval please sign the commit

Added sign-off in the commit. Please review again.

Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 839cab1 into Samsung:main Mar 26, 2024
8 checks passed
@o-konoval o-konoval deleted the fix-Correct-link-in-quick-start-guide-and-build.md branch March 26, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants