-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modify single scan feature #463
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
============================================
- Coverage 90.74% 90.65% -0.09%
- Complexity 489 491 +2
============================================
Files 47 47
Lines 1729 1745 +16
Branches 208 210 +2
============================================
+ Hits 1569 1582 +13
Misses 97 97
- Partials 63 66 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see any updates compared to the diff I provided.
Signed-off-by: Mykola Rudyk <[email protected]>
Signed-off-by: Mykola Rudyk <[email protected]>
723f53f
to
bd874c3
Compare
@@ -14,6 +14,7 @@ license_conflict=db | |||
|
|||
# Logger configuration | |||
logging.pattern.console=%d{dd-MM-yyyy HH:mm:ss.SSS} %magenta([%thread]) %highlight(%-5level) %logger.%M - %msg%n | |||
spring.profiles.active=singlescan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not required here.
Also, please modify the next property in application-singlescan.properties
:
spring.datasource.url=jdbc:h2:mem:singlescan;DATABASE_TO_UPPER=false;MODE=MySQL;NON_KEYWORDS=USER;DB_CLOSE_ON_EXIT=FALSE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Mykola Rudyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job for fix the issue. Approved.
Pull Request
Description
Type of change
Please delete options that are not relevant.
Checklist: