-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch from Spring 2.7 to 3.2 #400
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=========================================
Coverage 90.90% 90.90%
Complexity 486 486
=========================================
Files 47 47
Lines 1737 1737
Branches 209 209
=========================================
Hits 1579 1579
Misses 94 94
Partials 64 64 ☔ View full report in Codecov by Sentry. |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested variant of deploy "Build and Run LPVS from Source Code" on basic scenarios- no issues:
2024-01-10T16:15:09.638+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 1
2024-01-10T16:15:09.686+02:00 INFO 45584 --- [ LPVS-ASYNC::1] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:16:25.162+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 2
2024-01-10T16:16:25.165+02:00 INFO 45584 --- [ LPVS-ASYNC::2] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:17:39.253+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 3
2024-01-10T16:17:39.255+02:00 INFO 45584 --- [ LPVS-ASYNC::3] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:18:58.722+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 4
2024-01-10T16:18:58.733+02:00 INFO 45584 --- [ LPVS-ASYNC::4] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:19:48.424+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 5
2024-01-10T16:19:48.426+02:00 INFO 45584 --- [ LPVS-ASYNC::5] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:20:56.730+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 6
2024-01-10T16:20:56.731+02:00 INFO 45584 --- [ LPVS-ASYNC::6] com.lpvs.service.LPVSQueueService : GitHub queue processing...
Needed additional tests with Docker scenarios- when it will be ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment- variant of deploy "Build and Run LPVS from Source Code" on basic scenarios- no issues.
Needed additional tests with Docker scenarios- when it will be ready.
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docker scenario tested - working properly.
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Signed-off-by: rnd4you <[email protected]>
Pull Request
Description
Spring 2.7 has been replaced with 3.2.
Fixes #351
Type of change
Testing
All previous tests that used to work with Spring 2.7 are operating well with Spring 3.2 as well.
Checklist: