Add unit tests for auth feature #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-rudyk
force-pushed
the
m.rudyk/refactor_auth
branch
from
f557aa8 to
6a0628e
Compare
m-rudyk
requested review from
tiokim,
MoonkiHong and
o-kopysov
as code owners
m-rudyk
force-pushed
the
m.rudyk/refactor_auth
branch
from
6a0628e to
1ecf451
Compare
o-kopysov
reviewed
Oct 24, 2023
v-kerimov
reviewed
Oct 24, 2023
| @@ -55,7 +56,8 @@ public enum OAuthAttributes { | |||
| this.of = of; | |||
| } | |||
|
|
|||
| public static MemberProfile extract(String registrationId, Map<String, Object> attributes) { | |||
| public static MemberProfile | |||
| extract(String registrationId, Map<String, Object> attributes) { | |||
There was a problem hiding this comment.
Doesn't seem to be a substantial change.
There was a problem hiding this comment.
thanks, good point.
v-kerimov
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor auth feature in order to cover with unit tests.
Move auth under entities folder;
Add unit tests to cover main functionality;
Fixes # (245, #242)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Below is just an example and you can delete it when you contribute.
Test Configuration:
Checklist: