fix: Missing link to the scan results in case of hub link present (#494)

Signed-off-by: Oleg Kopysov <[email protected]>
Samsung · Apr 16, 2024 · b397c38 · b397c38
1 parent 4b6e6d3
commit b397c38
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/src/main/java/com/lpvs/service/LPVSGitHubService.java b/src/main/java/com/lpvs/service/LPVSGitHubService.java
@@ -298,9 +298,9 @@ public void commentResults(
             }
         }
 
+        StringBuilder commitCommentBuilder = new StringBuilder();
         if (conflicts != null && conflicts.size() > 0) {
             hasConflicts = true;
-            StringBuilder commitCommentBuilder = new StringBuilder();
             commitCommentBuilder.append("**Detected license conflicts:**\n\n\n");
             commitCommentBuilder.append("<ul>");
             for (LPVSLicenseService.Conflict<String, String> conflict : conflicts) {
@@ -326,14 +326,14 @@ public void commentResults(
                 lpvsDetectedLicenseRepository.saveAndFlush(detectedIssue);
             }
             commitCommentBuilder.append("</ul>");
-            if (null != webhookConfig.getHubLink()) {
-                commitCommentBuilder.append(
-                        "\n\n###### <p align='right'>Check the validation details at the link(");
-                commitCommentBuilder.append(webhookConfig.getHubLink());
-                commitCommentBuilder.append(")</p>");
-            }
-            commitComment += commitCommentBuilder.toString();
         }
+        if (null != webhookConfig.getHubLink()) {
+            commitCommentBuilder.append(
+                    "\n\n###### <p align='right'>Check the validation details at the [link](");
+            commitCommentBuilder.append(webhookConfig.getHubLink());
+            commitCommentBuilder.append(")</p>");
+        }
+        commitComment += commitCommentBuilder.toString();
 
         if (hasProhibitedOrRestricted || hasConflicts) {
             lpvsPullRequest.setStatus(LPVSPullRequestStatus.ISSUES_DETECTED.toString());

diff --git a/src/test/java/com/lpvs/service/LPVSGitHubServiceTest.java b/src/test/java/com/lpvs/service/LPVSGitHubServiceTest.java
@@ -2179,7 +2179,7 @@ class TestCommentResults__ProhibitedPresentConflictsPresent {
                         + " */\n\n\n\n\n"
                         + "**Detected license conflicts:**\n\n\n"
                         + "<ul><li>MIT and Apache-1.0</li></ul>"
-                        + "\n\n###### <p align='right'>Check the validation details at the link()</p>";
+                        + "\n\n###### <p align='right'>Check the validation details at the [link]()</p>";
 
         @BeforeEach
         void setUp() {
@@ -2510,7 +2510,7 @@ class TestCommentResults__EmptyPresentConflictsPresent {
                         + " */\n\n\n\n\n"
                         + "**Detected license conflicts:**\n\n\n"
                         + "<ul><li>MIT and Apache-1.0</li></ul>"
-                        + "\n\n###### <p align='right'>Check the validation details at the link()</p>";
+                        + "\n\n###### <p align='right'>Check the validation details at the [link]()</p>";
 
         @BeforeEach
         void setUp() {
@@ -2840,7 +2840,7 @@ class TestCommentResults__UnreviewedPresentConflictsPresent {
                         + " */\n\n\n\n\n"
                         + "**Detected license conflicts:**\n\n\n"
                         + "<ul><li>MIT and Apache-1.0</li></ul>"
-                        + "\n\n###### <p align='right'>Check the validation details at the link()</p>";
+                        + "\n\n###### <p align='right'>Check the validation details at the [link]()</p>";
 
         @BeforeEach
         void setUp() {
@@ -3172,7 +3172,7 @@ class TestCommentResults__RestrictedPresentConflictsPresent {
                         + " */\n\n\n\n\n"
                         + "**Detected license conflicts:**\n\n\n"
                         + "<ul><li>MIT and Apache-1.0</li></ul>"
-                        + "\n\n###### <p align='right'>Check the validation details at the link()</p>";
+                        + "\n\n###### <p align='right'>Check the validation details at the [link]()</p>";
 
         @BeforeEach
         void setUp() {