Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check for handling error in decryption function #88

Merged
merged 2 commits into from
Nov 17, 2023
Merged

add check for handling error in decryption function #88

merged 2 commits into from
Nov 17, 2023

Conversation

yuvrajsab
Copy link
Member

Description

Add try catch to prevent malformed UTF-8 error while decoding the loginId and password. Now, if get that error we will return an empty string.

Changes

  • Login API in api.controller.ts

@yuvrajsab yuvrajsab requested a review from choxx November 17, 2023 10:20
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 6902719184

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 24.097%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/api.controller.ts 0 8 0.0%
Totals Coverage Status
Change from base Build 6258024352: -0.05%
Covered Lines: 609
Relevant Lines: 2261
💛 - Coveralls

@yuvrajsab yuvrajsab marked this pull request as draft November 17, 2023 10:46
@choxx choxx marked this pull request as ready for review November 17, 2023 12:31
@choxx choxx merged commit 15ad91b into master Nov 17, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choxx choxx choxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvrajsab @choxx