Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed validations issue #85

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fixed validations issue #85

merged 1 commit into from
Sep 1, 2023

Conversation

choxx
Copy link
Collaborator

@choxx choxx commented Sep 1, 2023

Description

Validation Pipes at api module lever were causing failure of other general APIs. This PR fixes that issue.

Changes

We have now enabled validations on specific APIs of API Controller instead of module level before.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Pull Request Test Coverage Report for Build 6048998971

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 24.121%

Totals Coverage Status
Change from base Build 5923127500: -0.03%
Covered Lines: 608
Relevant Lines: 2254

💛 - Coveralls

@choxx choxx requested a review from amit-s19 September 1, 2023 11:46
Copy link
Contributor

@amit-s19 amit-s19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amit-s19 amit-s19 merged commit ac66239 into master Sep 1, 2023
3 of 4 checks passed
@choxx choxx deleted the hotfix/validation-bug branch November 7, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants