API & Client - create notification on user registration

fittrackee/tests/users/test_auth_api.py

@@ -16,6 +16,7 @@
 from fittrackee.tests.comments.mixins import CommentMixin
 from fittrackee.users.models import (
     BlacklistedToken,
+    Notification,
     User,
     UserDataExport,
     UserSportPreference,
@@ -484,6 +485,44 @@ def test_it_does_not_call_account_confirmation_email_if_user_already_exists(  #
 
         account_confirmation_email_mock.send.assert_not_called()
 
+    def test_it_creates_notifications_for_admins_on_registration(
+        self,
+        app: Flask,
+        user_1_admin: User,
+        user_2_admin: User,
+        user_3: User,
+        account_confirmation_email_mock: Mock,
+    ) -> None:
+        email = self.random_email()
+        client = app.test_client()
+
+        client.post(
+            '/api/auth/register',
+            data=json.dumps(
+                dict(
+                    username=self.random_string(),
+                    email=email,
+                    password=self.random_string(),
+                    accepted_policy=True,
+                )
+            ),
+            content_type='application/json',
+        )
+
+        new_user = User.query.filter_by(email=email).first()
+        notification = Notification.query.filter_by(
+            event_type='account_creation', event_object_id=new_user.id
+        ).all()
+        assert len(notification) == 2
+        for notification in notification:
+            assert notification.created_at == new_user.created_at
+            assert notification.from_user_id == new_user.id
+            assert notification.event_object_id == new_user.id
+            assert notification.to_user_id in [
+                user_1_admin.id,
+                user_2_admin.id,
+            ]
+
 
 class TestUserLogin(ApiTestCaseMixin):
     def test_it_returns_error_if_payload_is_empty(self, app: Flask) -> None:

fittrackee/users/auth.py

@@ -54,6 +54,7 @@
 from .models import (
     BlacklistedToken,
     BlockedUser,
+    Notification,
     User,
     UserDataExport,
     UserSportPreference,
@@ -184,6 +185,18 @@ def register_user() -> Union[Tuple[Dict, int], HttpResponse]:
         if new_user:
             new_user.language = language
             new_user.accepted_policy_date = datetime.datetime.utcnow()
+            for admin in User.query.filter(
+                User.admin == True,  # noqa
+                User.is_active == True,  # noqa
+            ).all():
+                notification = Notification(
+                    from_user_id=new_user.id,
+                    to_user_id=admin.id,
+                    created_at=new_user.created_at,
+                    event_type='account_creation',
+                    event_object_id=new_user.id,
+                )
+                db.session.add(notification)
             db.session.commit()
             send_account_confirmation_email(new_user)
 

fittrackee/users/models.py

@@ -40,6 +40,7 @@
 )
 
 NOTIFICATION_TYPES = [
+    'account_creation',
     'comment_like',
     'comment_reply',
     'comment_suspension',

fittrackee_client/src/components/Notifications/NotificationDetail.vue

@@ -181,10 +181,14 @@
     )
   }
   function displayRelationshipCard(notificationType: TNotificationType) {
-    return ['follow', 'follow_request'].includes(notificationType)
+    return ['follow', 'follow_request', 'account_creation'].includes(
+      notificationType
+    )
   }
   function getUserAction(notificationType: TNotificationType): string {
     switch (notificationType) {
+      case 'account_creation':
+        return 'notifications.SIGN_UP'
       case 'comment_like':
         return 'notifications.LIKED_YOUR_COMMENT'
       case 'comment_reply':

fittrackee_client/src/locales/en/notifications.json

@@ -16,6 +16,7 @@
   "REPORTED_USER_COMMENT": "reported this comment:",
   "REPORTED_USER_WORKOUT": "reported this workout:",
   "SEND_FOLLOW_REQUEST_TO_YOU": "send a follow request to you",
+  "SIGN_UP": "signed up",
   "STATUS": "Status",
   "TYPES": {
     "LABEL": "Type",

fittrackee_client/src/locales/fr/notifications.json

@@ -16,6 +16,7 @@
   "REPORTED_USER_COMMENT": "a signalé ce commentaire :",
   "REPORTED_USER_WORKOUT": "a signalé cette séance :",
   "SEND_FOLLOW_REQUEST_TO_YOU": "souhaite s'abonner",
+  "SIGN_UP": "s'est inscrit.e",
   "STATUS": "Status",
   "TYPES": {
     "LABEL": "Type",

fittrackee_client/src/types/notifications.ts

@@ -3,6 +3,7 @@ import type { IUserReportAction, IUserProfile } from '@/types/user'
 import type { IComment, IWorkout } from '@/types/workouts'
 
 export type TNotificationType =
+  | 'account_creation'
   | 'comment_like'
   | 'comment_reply'
   | 'comment_suspension'