Skip to content

Commit

Permalink
fix versions
Browse files Browse the repository at this point in the history
  • Loading branch information
SalvatorePreviti committed Jun 8, 2023
1 parent 5e26f62 commit 1856027
Show file tree
Hide file tree
Showing 7 changed files with 53 additions and 54 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
needs: test
strategy:
matrix:
node-version: ["12.13.0", "14.13.0", "16.14.0", "18.1.0", "20.0.0"]
node-version: ["12.20.0", "14.13.0", "16.14.0", "18.1.0", "20.3.0"]
os: [ubuntu-latest, macos-latest, windows-2019]
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
needs: test
strategy:
matrix:
node-version: ["12.13.0", "14.13.0", "16.14.0", "18.1.0", "20.0.0"]
node-version: ["12.20.0", "14.13.0", "16.14.0", "18.1.0", "20.3.0"]
os: [ubuntu-20.04, windows-2019, macos-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ If you want to contribute and submit a pull request, use the master branch.

## Supported node versions

Node 12.13+, 14.13+, 16.14+, 18+, 20+ are currently supported.
Node 12.20+, 14.13+, 16.14+, 18+, 20+ are currently supported.

Node 8 and 10 support was dropped in release 2.0

Expand Down
17 changes: 8 additions & 9 deletions node-pre-gyp.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,19 @@ if (customRebuildIdx <= 0) {
const main = async () => {
console.log("* rebuild...");

let glibc;
try {
// eslint-disable-next-line node/no-unsupported-features/node-builtins
const header = process.report.getReport().header;
const glibc = header.glibcVersionRuntime;
console.log("versions:", {
node: process.version,
v8: process.versions.v8,
glibc,
});

console.log(`* v8 version: ${header.v8Version}`);
console.log(`* node version: ${header.nodeVersion}`);
glibc = header.glibcVersionRuntime;
} catch {}

console.log("versions:", {
node: process.version,
v8: process.versions.v8,
glibc: glibc || null,
});

console.time("rebuild");
await forkAsync(__filename, ["rebuild"]);
console.log();
Expand Down
76 changes: 38 additions & 38 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"url": "git+https://github.com/SalvatorePreviti/roaring-node.git"
},
"engines": {
"node": ">=12.13.0"
"node": ">=12.20.0"
},
"main": "index.js",
"types": "index.d.ts",
Expand Down Expand Up @@ -81,7 +81,7 @@
"node-gyp": "^9.3.1"
},
"devDependencies": {
"@balsamic/eslint-config": "^0.4.1",
"@balsamic/eslint-config": "^0.4.3",
"@octokit/rest": "^19.0.11",
"@types/chai": "^4.3.5",
"@types/chai-as-promised": "^7.1.5",
Expand All @@ -107,7 +107,7 @@
"ts-node": "^10.9.1",
"tslib": "^2.5.3",
"typedoc": "^0.24.8",
"typescript": "^5.1.3"
"typescript": "5.0.4"
},
"gypfile": true,
"roaring_version": "1.1.5"
Expand Down
2 changes: 1 addition & 1 deletion scripts/prebuild-local.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const { spawnAsync, mergeDirs, runMain, ROOT_FOLDER, forkAsync } = require("./li

const { startPublishAssets } = require("./node-pre-gyp-publish");

const NODE_VERSIONS = ["12.13.0", "14.13.0", "16.14.0", "18.1.0", "20.0.0"];
const NODE_VERSIONS = ["12.20.0", "14.13.0", "16.14.0", "18.1.0", "20.3.0"];

const NATIVE_DIR = path.resolve(ROOT_FOLDER, "native");
const STAGE_DIR = path.resolve(ROOT_FOLDER, "build/stage");
Expand Down

0 comments on commit 1856027

Please sign in to comment.