@W-16797436@ [App Extensibility ⚙️] Allow overrides to be disabled #2051
Conversation
| paths = expand(extensionEntries) | ||
| .filter(isEnabled) | ||
| .reverse() |
There was a problem hiding this comment.
Would you consider extracting the filtering logic for enabled extensions into a separate function to simplify buildCandidatePaths and perhaps include a test?
There was a problem hiding this comment.
I think a single line to filter doesn't really warrant being refactored, unless I'm just not understanding how that would be done. Also, I did add some tests that specifically pass extension entries that are disabled to ensure they are getting filtered out. Also the isEnabled function is tested too.
There was a problem hiding this comment.
Yeah, I assumed the logic was in the same function, but reading the code further, I see isEnabled is already a separate function with its own tests.
| const srcPath = path.join(projectDir, NODE_MODULES, extensionRef, SRC) | ||
| return [...acc, path.join(srcPath, OVERRIDES, importPath), path.join(srcPath, importPath)] | ||
| }, []) | ||
| paths = expand(extensionEntries) |
There was a problem hiding this comment.
Should we validate the paths exsist before processing them?
There was a problem hiding this comment.
No. This already happen internally in the resolve call so we can just lean on it to do the right thing.
| @@ -1,4 +1,5 @@ | |||
| ## v4.0.0-dev (Jun 21, 2024) | |||
| - Overrides in `disabled` Application Extensions will take no effect. [#2051](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2051) | |||
There was a problem hiding this comment.
| - Overrides in `disabled` Application Extensions will take no effect. [#2051](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2051) | |
| - Overrides in `enabled: false` Application Extensions will take no effect. [#2051](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2051) |
There was a problem hiding this comment.
i'm not sure if you want to call out the actual property name enabled
Description
In this PR I ensure that any overrides that exist in a project DO NOT get used in the module resolution and building of the bundled code if they are DISABLED. This is mirror behaviour of how we handle the Application Extension initialization.
There is 1 caveat however, and that is that you'll most likely need to restart your dev server to see the effects of disabling extensions specifically with overrides as the module resolution logic doesn't re-run. We'll make sure we document that in a known behaviours in a quip doc.
Types of Changes
Changes
buildCandidatePathsHow to Test-Drive This PR
typescript minimalproject and notice that there is a red border around the application.General