Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AG-1221 add SRM option to GCT subcategory dropdown options #1278

Merged
merged 6 commits into from
Jan 24, 2024
Merged

AG-1221 add SRM option to GCT subcategory dropdown options #1278

merged 6 commits into from
Jan 24, 2024

Conversation

sagely1
Copy link
Contributor

@sagely1 sagely1 commented Jan 22, 2024

No description provided.

@sagely1 sagely1 changed the title AG-1221 add SRM option to GCT subcategory dropdown options AG-1222 add SRM option to GCT subcategory dropdown options Jan 22, 2024
@sagely1 sagely1 changed the title AG-1222 add SRM option to GCT subcategory dropdown options AG-1221 add SRM option to GCT subcategory dropdown options Jan 22, 2024
@sagely1 sagely1 requested a review from hallieswan January 22, 2024 07:48
hallieswan
hallieswan reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@hallieswan hallieswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the menu and default order look good!

src/server/components/comparison.ts Outdated Show resolved Hide resolved
tests/gene-comparison-tool.spec.ts Outdated Show resolved Hide resolved
tests/gene-comparison-tool.spec.ts Outdated Show resolved Hide resolved
hallieswan
hallieswan reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@hallieswan hallieswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to the header label in the circle overlay looks good! Do the row names in the GCT table also need to be updated here, so that the uniprotid is conditionally hidden when the SRM option is selected?

@sagely1
Copy link
Contributor Author

sagely1 commented Jan 24, 2024

The update to the header label in the circle overlay looks good! Do the row names in the GCT table also need to be updated here, so that the uniprotid is conditionally hidden when the SRM option is selected?

Good question! I'll ask @JessterB

@JessterB
Copy link
Contributor

The update to the header label in the circle overlay looks good! Do the row names in the GCT table also need to be updated here, so that the uniprotid is conditionally hidden when the SRM option is selected?

Good question! I'll ask @JessterB

@sagely1 Yes, we do want to conditionally hide the uniprotid for SRM in the row names as well as in the overlay.

hallieswan
hallieswan approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@hallieswan hallieswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could consider adding a test to confirm that row names are displayed as expected for SRM vs other categories

@sagely1 sagely1 merged commit d85512d into Sage-Bionetworks:develop Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallieswan hallieswan hallieswan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagely1 @JessterB @hallieswan