Unpack the boxsize as a cosmo_array. #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjmcgibbon
approved these changes
Dec 5, 2024
| @@ -60,7 +60,9 @@ def test_soap_can_mask_spatial_and_non_spatial_actually_use(filename): | |||
| masses2 = data2.spherical_overdensity_200_mean.total_mass | |||
|
|
|||
| # Manually mask | |||
| custom_mask = (masses2 >= lower) & (masses2 <= upper) | |||
| custom_mask = ( | |||
| unyt.unyt_array(masses2.to_value(masses2.units), masses2.units) >= lower | |||
There was a problem hiding this comment.
Why is this needed, does masses2 not already support comparison?
There was a problem hiding this comment.
lower and upper are unyt_quantitys, not cosmo_arrays. This is correct given the type hints of constrain_mask used further up in the test, but correctly triggers a warning on comparison with masses2. Perhaps constrain_mask should be modified to expect cosmo_arrays. It would still work if given unyt_quantitys in that case but would raise warnings on receiving unyt_quantitys (which is what should happen in that case, I guess). If that happens then the change to custom_mask should be reverted (it will emit a warning in that case so shouldn't go unnoticed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
Finally got around to implementing this. It's set up to mimic the way units are applied to header fields.
One thing to consider is whether we're happy with how the non-cosmological case is handled. If the simulation is non-cosmological, then the
scale_factorwill default to 1.0 (because swiftsimio enforces that it exists). Thebox_sizeis then created as acosmo_arraywithcomoving=True, but that's acceptable becausescale_factor=1so it will just silently convert to physical if it ever needs to.If we're not happy with that, then some further introspection will be needed to figure out if the snapshot is non-cosmological.