raise error when unable to query the latest helm version #255
Conversation
Raise an error if the http get request fails to query `api.github.com` for the latest helm version Signed-off-by: Michael Fritch <[email protected]>
a25c502 hardcoded to a 'pre-release' version of helm (v3.9.0-rc.1), where the current 'feature release' can now be used (v3.11.0) Signed-off-by: Michael Fritch <[email protected]>
|
see also #256 which should fix the failing python 3.6 tox github action |
| version = "v3.9.0-rc.1" | ||
| r = requests.get(url) | ||
| r.raise_for_status() | ||
| version = r.json()["tag_name"] |
There was a problem hiding this comment.
This looks reasonable but according to the patch a25c502 it was needed by some reason the latest helm version, however it is hardcoded to particular version, so maybe just always downloaded given and tested version of helm instead querying from api.
Interesting that official tool to get helm does not use GitHub api, but parses it from the web UI:
https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
There was a problem hiding this comment.
I think using the latest feature release makes sense for CI pipeline ...
a25c502 required version v3.9.0 or greater, but SLES 15 SP4 Subpackages Updates is the only release that provides this requirement?
raise an error if the http get request fails to query
api.github.comfor the latest helm version
also use the latest helm feature release (v3.11.0) rather than hard-coding the the prior pre-release (v3.9.0-rc.1)
Signed-off-by: Michael Fritch [email protected]