-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong directory content copying resulting in repodata/repodata #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove stale `repodata/repodata` and `.old_*` directories which might still exist in customers RMT instances
We need to match for `product/` to detect license enabled repositories instead of `product` since RMT adds trailing slashes to all URLs.
felixsch
changed the title
Fix broken move metadata
Fix wrong directory content copying resulting in repodata/repodata
May 6, 2024
felixsch
force-pushed
the
fix-broken-move-metadata
branch
3 times, most recently
from
May 7, 2024 06:43
e21e11a
to
181de5c
Compare
felixsch
force-pushed
the
fix-broken-move-metadata
branch
from
May 7, 2024 12:54
181de5c
to
7e5b3f4
Compare
likhitha77
reviewed
May 7, 2024
likhitha77
reviewed
May 7, 2024
Co-authored-by: Likhitha Priya <[email protected]>
ngetahun
requested changes
May 10, 2024
Co-authored-by: Natnael Getahun <[email protected]>
ngetahun
approved these changes
May 10, 2024
ngetahun
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cleaning up wrong verified that the wrong directory gets cleaned uprepodata/repodata
is not implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
card: https://trello.com/c/DZm26xHm/3342-rmt-metadata-is-not-correctly-moved-to-repoistory-root-but-into-repodata-repodata-if-exists
issue: #1136
Due to changed mechanics after removing the
.old_*
backup mechanism from https://github.com/SUSE/rmt/blob/master/lib/rmt/mirror/base.rb#L134 in 5aae83e does move the directory into the destination directory if already exists, instead of merging them.Additional fixes in this PR:
Saw that licenses are not correctly mirrored if available. This is due to we scan for repositories ending with
product
instead ofproducts/
. See second commit.Added a cleanup method obsolete or broken metadata. This means
.old_*
directories getting automatically removed andrepodata/repodata
is deleted if present.How to test this pull request:
Thanks for the review. I you have questions please do no hesitate to ask! 🚀
cheers!