Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop 1.57.1 → 1.57.2 (patch) #290

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 27, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.57.1 → 1.57.2) · Repo · Changelog

Release Notes

1.57.2

Bug fixes

  • #12274: Fix a false positive for Lint/Void when each's receiver is an object of Enumerator to which filter has been applied. (@koic)
  • #12291: Fix a false positive for Metrics/ClassLength when a class with a singleton class definition. (@koic)
  • #12293: Fix a false positive for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge and method chain. (@koic)
  • #12298: Fix a false positive for Style/RedundantParentheses when using a parenthesized hash literal as the first argument in a method call without parentheses. (@koic)
  • #12283: Fix an error for Style/SingleLineDoEndBlock when using single line do...end with no body. (@koic)
  • #12312: Fix an incorrect autocorrect for Style/HashSyntax when braced hash key and value are the same and it is used in if...else. (@koic)
  • #12307: Fix an infinite loop error for Layout/EndAlignment when EnforcedStyleAlignWith: variable and using a conditional statement in a method argument on the same line and end with method call is not aligned. (@koic)
  • #11652: Make --auto-gen-config generate inherit_from correctly inside ERB if. (@jonas054)
  • #12310: Drop base64 gem from runtime dependency. (@koic)
  • #12300: Fix an error for Style/IdenticalConditionalBranches when if...else with identical leading lines and using index assign. (@koic)
  • #12286: Fix false positives for Style/RedundantDoubleSplatHashBraces when using double splat with a hash literal enclosed in parenthesized ternary operator. (@koic)
  • #12279: Fix false positives for Lint/EmptyConditionalBody when missing 2nd if body with a comment. (@koic)
  • #12275: Fix a false positive for Style/RedundantDoubleSplatHashBraces when using double splat within block argument containing a hash literal in an array literal. (@koic)
  • #12284: Fix false positives for Style/SingleArgumentDig when using some anonymous argument syntax. (@koic)
  • #12301: Make Style/RedundantFilterChain aware of safe navigation operator. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 28 commits:

↗️ rubocop-ast (indirect, 1.29.0 → 1.30.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 12 commits:

🗑️ base64 (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93d3a1f) 100.00% compared to head (16e6420) 100.00%.

❗ Current head 16e6420 differs from pull request most recent head 1525249. Consider uploading reports for the commit 1525249 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines          616       616           
=========================================
  Hits           616       616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digitaltom digitaltom merged commit 7d7eba7 into main Nov 29, 2023
7 checks passed
@depfu depfu bot deleted the depfu/update/rubocop-1.57.2 branch November 29, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant