Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop 1.55.1 → 1.56.2 (minor) #269

Closed
wants to merge 1 commit into from
Closed

Update rubocop 1.55.1 → 1.56.2 (minor) #269

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 30, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.55.1 → 1.56.2) · Repo · Changelog

Release Notes

1.56.2 (from changelog)

* [#12138](https://github.com//issues/12138): Fix a false positive for `Layout/LineContinuationLeadingSpace` when a backslash is part of a multiline string literal. ([@ymap][])
* [#12155](https://github.com//pull/12155): Fix false positive for `Layout/RedundantLineBreak` when using a modified singleton method definition. ([@koic][])
* [#12143](https://github.com//issues/12143): Fix a false positive for `Lint/ToEnumArguments` when using anonymous keyword arguments forwarding. ([@koic][])
* [#12148](https://github.com//pull/12148): Fix an incorrect autocorrect for `Lint/NonAtomicFileOperation` when using `FileUtils.remove_dir`, `FileUtils.remove_entry`, or `FileUtils.remove_entry_secure`. ([@koic][])
* [#12141](https://github.com//issues/12141): Fix false positive for `Style/ArgumentsForwarding` when method def includes additional kwargs. ([@owst][])
* [#12154](https://github.com//issues/12154): Fix incorrect `diagnosticProvider` value of LSP. ([@koic][])

1.56.1

Bug fixes

  • #12136: Fix a false negative for Layout/LeadingCommentSpace when using #+ or #- as they are not RDoc comments. (@koic)
  • #12113: Fix a false positive for Bundler/DuplicatedGroup when groups are duplicated but source, git, platforms, or path values are different. (@koic)
  • #12134: Fix a false positive for Style/MethodCallWithArgsParentheses when parentheses are used in one-line in pattern matching. (@koic)
  • #12111: Fix an error for Bundler/DuplicatedGroup group declaration has keyword option. (@koic)
  • #12109: Fix an error for Style/ArgumentsForwarding cop when forwarding kwargs/block arg and an additional arg. (@ydah)
  • #12117: Fix a false positive for Style/ArgumentsForwarding cop when not always forwarding block. (@owst)
  • #12115: Fix an error for Style/Lambda when using numbered parameter with a multiline -> call. (@koic)
  • #12124: Fix false positives for Style/RedundantParentheses when parentheses in super or yield call with multiline style argument. (@koic)
  • #12120: Fix false positives for Style/SymbolArray when %i array containing unescaped [, ], (, or ). (@koic)
  • #12133: Fix Style/RedundantSelfAssignmentBranch to handle heredocs. (@r7kamura)
  • #12105: Fix target ruby Gem::Requirement matcher and version parsing to support multiple version constraints. (@ItsEcholot)

1.56.0

New features

  • #12074: Add new Bundler/DuplicatedGroup cop. (@OwlKing)
  • #12078: Make LSP server support rubocop.formatAutocorrectsAll execute command. (@koic)

Bug fixes

  • #12106: Fix a false negative for Style/RedundantReturn when returning value with guard clause and return is used. (@koic)
  • #12095: Fix a false positive for Style/Alias when EncforcedStyle: prefer_alias and using alias with interpolated symbol argument. (@koic)
  • #12098: Fix a false positive for Style/ClassEqualityComparison when comparing interpolated string class name for equality. (@koic)
  • #12102: Fix an error for Style/LambdaCall when using nested lambda call x.().(). (@koic)
  • #12099: Fix an incorrect autocorrect for Style/Alias when EncforcedStyle: prefer_alias_method and using alias with interpolated symbol argument. (@koic)
  • #12085: Fix an error for Lint/SuppressedException when AllowNil: true is set and endless method definition is used. (@koic)
  • #12087: Fix false positives for Style/ArgumentsForwarding with additional args/kwargs in def/send nodes. (@owst)
  • #12071: Fix Style/SymbolArray false positives when using square brackets or interpolation in a symbol literal in a percent style array. (@jasondoc3)
  • #12061: Support regex in StringLiteralsInInterpolation. (@jonas054)
  • #12091: With --fail-level A ignore non-correctable offenses at :info severity. (@naveg)

Changes

  • #12094: Add base64 gem to runtime dependency to suppress Ruby 3.3's warning. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 71 commits:

🆕 base64 (added, 0.1.1)

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (447eebe) 100.00% compared to head (307367c) 100.00%.

❗ Current head 307367c differs from pull request most recent head b3b99d1. Consider uploading reports for the commit b3b99d1 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #269   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines          616       616           
=========================================
  Hits           616       616

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@depfu depfu bot mentioned this pull request Aug 30, 2023
Closed
@depfu
Copy link
Contributor Author

depfu bot commented Sep 12, 2023

Closed in favor of #274.

@depfu depfu bot closed this Sep 12, 2023
@depfu depfu bot deleted the depfu/update/rubocop-1.56.2 branch September 12, 2023 07:49
@depfu
Copy link
Contributor Author

depfu bot commented Sep 12, 2023

Closed in favor of #274.

2 similar comments
@depfu
Copy link
Contributor Author

depfu bot commented Sep 12, 2023

Closed in favor of #274.

@depfu
Copy link
Contributor Author

depfu bot commented Sep 12, 2023

Closed in favor of #274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants