Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a workflow for nitpicking on trailing spaces and similar issues (to discuss) #892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a workflow for nitpicking on trailing spaces and similar issues (to discuss) #892

wants to merge 1 commit into from

Commits on Jan 28, 2022

  1. GHA: Introduce new workflow to nitpick on trailing spaces and long lines 

    * This is the hackiest possible implementation, if we agree to do this,
  it would probably be best to use an own GitHub Action action for it.
* I wanted to use "continue-on-error: true" in my steps but while that
  correctly recognizes all issues, people would not see the evil red
  X marking the check failed.
* Output is not particularly pretty currently.
* On longer PRs, the current output may be a bit confusing, because we
  don't try to give file names/lines that failed.
* This only runs on PRs. Running on push would mean running after the
  damage is already dones.
* This will only compare main..my-branch, rather than each commit added
  to my-branch individually
* Checking out the 1.3 GB doc-sle repo for 10 seconds worth of scripts
  is a bit wasteful. Unfortunately, it would not work easily with any
  kind of --depth setting. :/
* This workflow fails the line length criteria too.
    Stefan Knorr committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    e169312 View commit details
    Browse the repository at this point in the history