Fix dropped attributes from vector types #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang handle __attribute__((__vector_size__((N)))) attributes differently from the general case. While other attributes resides in the AttrVec structure, those are hardcoded in the VectorType structure and the AttrVec may contain nothing. Hence we also need to trigger the Get_Expanded_Loc for this case as well even if we can't get the SourceLocation of this attribute. Signed-off-by: Giuliano Belinassi <[email protected]>
The bultin construct `__builtin_convertvector(a, b)` is not a function but rather a special kind of Expr. Hence we need a visitor to catch it correctly. Signed-off-by: Giuliano Belinassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang handle attribute((vector_size((N)))) attributes differently from the general case. While other attributes resides in the AttrVec structure, those are hardcoded in the VectorType structure and the AttrVec may contain nothing. Hence we also need to trigger the Get_Expanded_Loc for this case as well even if we can't get the SourceLocation of this attribute.
Closes #68 (I hope for the last time! :) )