Fix redeclaration of RecordDecl in Records defined in array variables #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some cases where a variable is declared as follows:
static const struct mount_opts
{
int token;
int mount_opts;
int flags;
} ext4_mount_opts[] = {
{1, 1, 1}
};
in this case, the `ext4_mount_opts` array is declared together with its
type, thus resulting in Clang splitting this into two decls in its AST:
struct mount_opts
{
int token;
int mount_opts;
int flags;
};
static const struct ext4_mount_opts[] = {
{1, 1, 1}
};
but since we try to get what the user wrote, it results in two declarations
of `struct mount_opts`, thus clang-extract fails because of a redeclaration
error. But since `ext4_mount_opts` is an array, geting its type returns
an array type, not the struct declaration itself, hence check for this
case as well.
Signed-off-by: Giuliano Belinassi <[email protected]>
|
Now it shows a different issue regarding symbol renaming =/ |
|
What issue? |
With the resolved issue, now it reports missing symbol: But the symbol is there, and it's also present in the ext4.ko module too. |
This seems to be another issue. Perhaps open another issue with more details of this problem? |
|
Sure, I'll check this again once I start working on this livepatch again. |
|
@giulianobelinassi indeed, the error message changes, and it's not a different issue. You can merge this PR as this fixed the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where a variable is declared as follows:
in this case, the
ext4_mount_optsarray is declared together with its type, thus resulting in Clang splitting this into two decls in its AST:but since we try to get what the user wrote, it results in two declarations of
struct mount_opts, thus clang-extract fails because of a redeclaration error. But sinceext4_mount_optsis an array, geting its type returns an array type, not the struct declaration itself, hence check for this case as well.