Fix CompleteDefinition of struct being dragged into output because of union fields #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… union field
On the following example:
```
struct ll {
union {
unsigned long key;
void *key_ptr;
};
struct ll *next;
};
```
Even if we don't need the full definition of `ll` it is dragged into
the output because when analyzing this `union` field it tries to go
up and set `struct ll` as having its body necessary once there was
no way for it to know that it went there as a consequence of adding
`struct ll` to the closure, rather than it being there because of
a foward union declaration inside a struct. This commit fixes
this by pushing the Decls into a stack as a way to know which
declarations we are currently analyzing.
Signed-off-by: Giuliano Belinassi <[email protected]>
|
it reduced the LoC of cmdline_proc_show from 105 to 67! 🚢 it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the following example:
Even if we don't need the full definition of
llit is dragged into the output because when analyzing thisunionfield it tries to go up and setstruct llas having its body necessary once there was no way for it to know that it went there as a consequence of addingstruct llto the closure, rather than it being there because of a foward union declaration inside a struct. This commit fixes this by pushing the Decls into a stack as a way to know which declarations we are currently analyzing.