Tumbleweed testsuite fixes #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
reviewed
Aug 8, 2023
grisu48
reviewed
Aug 8, 2023
They wouldn't be able to report the flavor anyway
The sizes are slightly larger (Newer, aka bigger busybox package) and /bin == /usr/bin so more files are in there that we need to skip
There are some unfinished bloat items in tumbleweed, raise the bar for now
dirkmueller
force-pushed
the
tumbleweed_testsuite-fixes
branch
from
2704099
to
27a218e
Compare
dcermak
reviewed
Aug 9, 2023
| @@ -105,9 +105,10 @@ def test_product(auto_container): | |||
| OS_VERSION != "tumbleweed", | |||
| reason="product flavors only available for openSUSE", | |||
| ) | |||
| def test_opensuse_product_flavor(auto_container): | |||
| @pytest.mark.parametrize("container", CONTAINERS_WITH_ZYPPER, indirect=True) | |||
There was a problem hiding this comment.
Just out of curiosity, why is this change necessary?
There was a problem hiding this comment.
I tried to explain it in the commit message.
They wouldn't be able to report the flavor anyway
It is necessary because the micro (?) container doesn't have rpm(1) which causes the test to fail for unrelated reasons. There's no variable that lists containers with rpm, and we don't need it as the flavor only matters for containers that can and are running zypper.
grisu48
approved these changes
Aug 9, 2023
rcmadhankumar
pushed a commit
that referenced
this pull request
Aug 30, 2024
Tumbleweed testsuite fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.