Skip to content

Commit

Permalink
Avoid FIXME comments to make pylint happy
Browse files Browse the repository at this point in the history
  • Loading branch information
dirkmueller committed Nov 13, 2024
1 parent 8f04873 commit 7265b39
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion tests/test_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def test_systemd_no_udev_present(self, auto_container):
def test_systemd_boottime(self, auto_container):
"""Ensure the container startup time is below 5 seconds"""

# FIXME: Temporary workaround: While using emulated workers, the startup time test doesn't make sense.'
# https://github.com/SUSE/BCI-tests/issues/647
if auto_container.connection.system_info.arch == "ppc64le":
pytest.skip(
"boottime test temporarily disabled on emulated ppc64le workers."
Expand Down
6 changes: 4 additions & 2 deletions tests/test_mariadb.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from pytest_container.container import container_and_marks_from_pytest_param
from pytest_container.pod import Pod
from pytest_container.pod import PodData
from pytest_container.runtime import LOCALHOST
from pytest_container.runtime import OciRuntimeBase
from tenacity import retry
from tenacity import stop_after_attempt
Expand Down Expand Up @@ -82,10 +83,11 @@ def _generate_test_matrix() -> List[ParameterSet]:
return params


## FIXME Increased attempts from 5 to 8 due to https://github.com/SUSE/BCI-tests/issues/647
@retry(
wait=wait_exponential(multiplier=1, min=4, max=10),
stop=stop_after_attempt(8),
stop=stop_after_attempt(
8 if LOCALHOST.system_info.arch == "ppc64le" else 5
),
)
def _wait_for_server(connection):
connection.check_output("healthcheck.sh --connect")
Expand Down
2 changes: 1 addition & 1 deletion tests/test_postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def _generate_test_matrix() -> List[ParameterSet]:
extra_launch_args=(
["--user", username] if username else []
),
# FIXME https://github.com/SUSE/BCI-tests/issues/647
# https://github.com/SUSE/BCI-tests/issues/647
healthcheck_timeout=(
timedelta(minutes=3)
if LOCALHOST.system_info.arch == "ppc64le"
Expand Down

0 comments on commit 7265b39

Please sign in to comment.