Fix memory leak when reading group input. (#101)

Since this occurs in a potentially endless loop, a malicious user could cause resource exhaustion. Co-authored-by: Martin Lambers <[email protected]>
SURFscz · Oct 18, 2024 · 5e8705d · 5e8705d
1 parent 68fcf22
commit 5e8705d
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/pam_weblogin.c b/src/pam_weblogin.c
@@ -234,6 +234,7 @@ PAM_EXTERN int pam_sm_authenticate(pam_handle_t *pamh, UNUSED int flags, int arg
 						}
 						char *group_input = tty_input(pamh, PROMPT_GROUP, PAM_PROMPT_ECHO_ON);
 						group = strtol(group_input, &end, 10);
+						free(group_input);
 						range_error = errno == ERANGE;
 						if (group < 1 || group > max_groups || range_error)
 						{