Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying ranges of vlans in tagged_vlan_list #373

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

indy-independence
Copy link
Member

No description provided.

@indy-independence indy-independence added this to the v1.7.0 milestone Oct 9, 2024
@indy-independence indy-independence added the enhancement New feature or request label Oct 9, 2024
Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.47%. Comparing base (5b5b02f) to head (f2b9436).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/cnaas_nms/db/settings_fields.py 37.50% 5 Missing ⚠️
src/cnaas_nms/db/settings.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #373      +/-   ##
===========================================
+ Coverage    64.46%   64.47%   +0.01%     
===========================================
  Files           75       75              
  Lines         8166     8175       +9     
===========================================
+ Hits          5264     5271       +7     
- Misses        2902     2904       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@indy-independence indy-independence merged commit 1824065 into develop Oct 21, 2024
8 of 9 checks passed
@indy-independence indy-independence deleted the feature.tagged_vlan_list_range branch October 21, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant