Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying custom metric value for fabric interfaces etc #357

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

indy-independence
Copy link
Member

Also allow some extra fields like mtu, tags to fabric interfaces. Fix docs for radius settings

… some extra fields like mtu, tags to fabric interfaces. Fix docs for radius settings
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.55%. Comparing base (b0d4855) to head (fe282d6).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/cnaas_nms/devicehandler/sync_devices.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #357      +/-   ##
===========================================
+ Coverage    64.45%   64.55%   +0.09%     
===========================================
  Files           74       74              
  Lines         8075     8080       +5     
===========================================
+ Hits          5205     5216      +11     
+ Misses        2870     2864       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 27, 2024

@indy-independence indy-independence merged commit 24f9cda into develop Jul 1, 2024
8 of 9 checks passed
@indy-independence indy-independence deleted the feature.fabric_metric_setting branch July 1, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant