es_wifi: fix start client connection for UDP sockets #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALABSTM
added
bug
|
ST Internal Reference: 188471 |
RJMSTM
added
the
internal bug tracker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request fixes an issue with the
ES_WIFI_StartClientConnectionfunction when using UDP socket: commands P3 and P4 (respectively to set remote IP address and port) must be executed not only for TCP/SSL connection. Indeed, while trying to open an UDP socket, we have to set the UDP server address and port!!Reference documentation from Inventek at https://www.inventeksys.com/iwin/wp-content/uploads/IWIN_Command_Set_Users_Manual.pdf does not limit executing P3 and P4 commands to TCP/SSL.
Implementation from getting-started example from Azure RTOS also made this modification. See https://github.com/eclipse-threadx/getting-started/blob/37ff82f757070f3fa5364acb1ac06fcc7a5b9d38/STMicroelectronics/B-L475E-IOT01A/lib/netx_driver/inventek/es_wifi.c#L1635.