Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update testing versions #86

Merged
merged 7 commits into from
Feb 16, 2024
Merged

update testing versions #86

merged 7 commits into from
Feb 16, 2024

Conversation

rpiazza
Copy link
Contributor

@rpiazza rpiazza commented Feb 6, 2024

@clenk Can you review these changes?

I will delete the commented out lines before I merge.

I couldn't get the tests with the profile spreadsheet to work. Maybe you can. It said the excel file was "corrupt"

@rpiazza rpiazza requested a review from clenk February 6, 2024 14:38
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to replace nosetests with pytest instead of just running the tests with python.

There are still some additional six imports that we could replace.

Still need to investigate the spreadsheet (I can open it in Excel just fine).

@rpiazza
Copy link
Contributor Author

rpiazza commented Feb 6, 2024

I wanted to do minimal changes - but if you think you could quickly move to pytest and remove remaining six, go for it.
I'm more concerned about travis :-(
Yes - the excel file seems fine

@rpiazza rpiazza merged commit 1f26704 into master Feb 16, 2024
10 checks passed
@clenk clenk deleted the update-testing-versions branch February 16, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants