Move run_as_os_thread from hpx::threads to hpx:: #476
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, changing the namespace make Octo-Tiger incompatible with HPX 1.9.1 as it is still using the old one (hence the failing tests). I think we should postpone this PR at least until the next stable HPX release! I will attempt to fix the issue with the hipcc compilation on the HPX side though so that we can still use HPX master on AMD devices if required! |
|
@G-071 Since HPX 1.10 is releases could we switch to this version and merge the pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_as_os_thread was moved to a different namespace within HPX. This caused some deprecation warnings (and in the case of hipcc actually some compilation errors). This PR should fix that by using the updated namespace.