Feat/merge in system text json branch #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Integration test fails on write/update : Seed database with non-modified Server
…endency' into feat/merge-in-system-text-json-branch
lxatstariongroup
requested review from
samatstariongroup and
antoineatstariongroup
samatstariongroup
requested changes
Nov 27, 2024
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="AuthenticatorPlugin{TProperties, TConnector}"/> class. | ||
| /// </summary> | ||
| protected AuthenticatorPlugin() | ||
| { | ||
| this.LoadConfig(); | ||
| this.InitializeConnectors(); | ||
| this.JsonSerializerOptions = new JsonSerializerOptions(JsonSerializerOptions.Default); |
There was a problem hiding this comment.
i thik this needs to be refactored
There was a problem hiding this comment.
It is only used for Deserialization of AuthenticatorConfig. No need for CDP4=COMET stuff there imho. Why would we refactor and what would we refactor?
CometServer/ChangeNotification/Subscription/ChangeNotificationSubscription.cs
Show resolved
Hide resolved
CometServer/ChangeNotification/UserPreference/ChangeNotificationSubscriptionUserPreference.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Feat/merge in system text json branch