Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat #701 Allow tabs to be reordered and move between split screens + #700 Limit split screen to 2 views max #708

Conversation

joao4all
Copy link
Contributor

@joao4all joao4all commented Jul 23, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Closes #701 Allow tabs to be reordered and move between split screens
Closes #700 Limit the amount of split screens to 2 views max

To achieve this task, SortableList's from Blazor Sortable were used. In order to make it more customizable, some aditional parameters (9) were needed for the component, thats why there is a sonarqube "issue". For further information about Blazor Sortable, check this microsoft devblog article

TODO
- Move tabs between panels
- Document SortableList and download its js file
- Refactors
- Unit tests
TODO
- Document SortableList and download its js file
- A todo in tab panel information
- Refactors
- Unit tests
Copy link

sonarcloud bot commented Jul 23, 2024

@joao4all joao4all merged commit 0b80461 into development Jul 23, 2024
6 checks passed
@joao4all joao4all deleted the feat/GH701-allow-tabs-to-be-reordered-and-move-between-split-screens branch July 23, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants