Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Common] Update dashboard title : Fix #453 #454

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

nabilatrhea
Copy link
Contributor

@nabilatrhea nabilatrhea commented Sep 14, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #453
Change the color of DashboardTitle
Move css defined in the Dashboard.razor.css file to the global css file

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3673007) 77.04% compared to head (5266b53) 77.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #454   +/-   ##
============================================
  Coverage        77.04%   77.04%           
============================================
  Files              310      310           
  Lines             6980     6980           
  Branches           713      713           
============================================
  Hits              5378     5378           
  Misses            1394     1394           
  Partials           208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nabilatrhea nabilatrhea merged commit 93187f9 into development Sep 14, 2023
9 checks passed
@nabilatrhea nabilatrhea deleted the feat/GH453-update-dashboard-title branch September 14, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Common] Update Dashboard title color and css isolation
2 participants