Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Remove DotNetZip, replace with SharpZipLib; fixes #349 #353

Merged
merged 4 commits into from
Oct 23, 2024
Merged

[REFACTOR] Remove DotNetZip, replace with SharpZipLib; fixes #349 #353

merged 4 commits into from
Oct 23, 2024

Conversation

lxatstariongroup
Copy link
Contributor

@lxatstariongroup lxatstariongroup commented Oct 21, 2024 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

[REFACTOR] Remove DotNetZip, replace with SharpZipLib; fixes #349

@lxatstariongroup lxatstariongroup self-assigned this Oct 21, 2024
@lxatstariongroup lxatstariongroup changed the title [REFACTOR] Remove DotNetZip, replace with System.IO.Compression; fixes #349 [REFACTOR] Remove DotNetZip, replace with SharpZipLib; fixes #349 Oct 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

samatstariongroup
samatstariongroup requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refactor the utils calss to make the methods extensions methods

please declare the bitness (256) as a static field (or the like) so this is explicit and we don;t have 256 in different places in the code

CDP4Common/Encryption/SharpZipLibUtils.cs Show resolved Hide resolved
@lxatstariongroup lxatstariongroup merged commit 8eebf87 into development Oct 23, 2024
8 checks passed
@lxatstariongroup lxatstariongroup deleted the feat/gh349-dotnetzip-out-system-io-compression-in branch October 23, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samatstariongroup samatstariongroup Awaiting requested review from samatstariongroup

Assignees

@lxatstariongroup lxatstariongroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Replace] dotnetzip with SharpZipLib - dotnetzip has been deprecated
2 participants
@lxatstariongroup @samatstariongroup